Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update circuitbreaker #688

Merged
merged 5 commits into from
Jul 7, 2022
Merged

update circuitbreaker #688

merged 5 commits into from
Jul 7, 2022

Conversation

suchen-sci
Copy link
Contributor

No description provided.

doc/cookbook/resilience.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #688 (c914a99) into main (8d2c6c8) will increase coverage by 0.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
+ Coverage   80.04%   80.06%   +0.01%     
==========================================
  Files          93       93              
  Lines       10100    10100              
==========================================
+ Hits         8085     8087       +2     
+ Misses       1540     1538       -2     
  Partials      475      475              
Impacted Files Coverage Δ
pkg/filters/proxy/pool.go 61.98% <71.42%> (ø)
pkg/filters/headerlookup/headerlookup.go 86.01% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2c6c8...c914a99. Read the comment docs.

@localvar
Copy link
Collaborator

localvar commented Jul 6, 2022

please also rename circuitbreak.go to circuitbreaker.go.

pkg/filters/proxy/pool.go Outdated Show resolved Hide resolved
@xxx7xxxx
Copy link
Contributor

xxx7xxxx commented Jul 6, 2022

Please fix test failure

@xxx7xxxx xxx7xxxx merged commit 84fba19 into easegress-io:main Jul 7, 2022
@suchen-sci suchen-sci deleted the update-circuitbreaker branch July 7, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants