Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update according to review comments #670

Merged
merged 1 commit into from
Jun 28, 2022
Merged

update according to review comments #670

merged 1 commit into from
Jun 28, 2022

Conversation

localvar
Copy link
Collaborator

No description provided.

@localvar localvar requested a review from suchen-sci June 27, 2022 00:25
@codecov-commenter
Copy link

Codecov Report

Merging #670 (5b99268) into pipeline (fdce281) will decrease coverage by 0.02%.
The diff coverage is 38.46%.

@@             Coverage Diff              @@
##           pipeline     #670      +/-   ##
============================================
- Coverage     80.01%   79.99%   -0.03%     
============================================
  Files            93       93              
  Lines         10100    10100              
============================================
- Hits           8082     8079       -3     
- Misses         1542     1545       +3     
  Partials        476      476              
Impacted Files Coverage Δ
pkg/filters/proxy/pool.go 61.98% <14.28%> (ø)
pkg/object/httpserver/mux.go 85.48% <66.66%> (ø)
pkg/object/autocertmanager/autocertmanager.go 91.42% <0.00%> (-2.05%) ⬇️
pkg/cluster/cluster.go 59.57% <0.00%> (-0.53%) ⬇️
pkg/object/mqttproxy/client.go 80.63% <0.00%> (+0.90%) ⬆️
pkg/filters/validator/basicauth.go 78.80% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdce281...5b99268. Read the comment docs.

@localvar localvar merged commit 4661301 into easegress-io:pipeline Jun 28, 2022
@localvar localvar deleted the review-comment branch June 28, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants