Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update according to review comments #667

Merged
merged 2 commits into from
Jun 24, 2022
Merged

update according to review comments #667

merged 2 commits into from
Jun 24, 2022

Conversation

localvar
Copy link
Collaborator

  • add version to spec
  • change status code to 503 when no response
  • add more debug log
  • fix typo

@localvar localvar requested a review from suchen-sci June 24, 2022 07:28
* add version to spec
* change status code to 503 when no response
* add more debug log
* fix typo
@codecov-commenter
Copy link

Codecov Report

Merging #667 (680f323) into pipeline (d3d3783) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##           pipeline     #667      +/-   ##
============================================
+ Coverage     78.69%   78.71%   +0.01%     
============================================
  Files            93       93              
  Lines         10098    10100       +2     
============================================
+ Hits           7947     7950       +3     
+ Misses         1681     1679       -2     
- Partials        470      471       +1     
Impacted Files Coverage Δ
pkg/filters/proxy/pool.go 61.98% <15.38%> (+1.16%) ⬆️
pkg/object/httpserver/mux.go 85.48% <72.22%> (-0.81%) ⬇️
pkg/filters/filters.go 69.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d3783...680f323. Read the comment docs.

@localvar localvar merged commit 760083d into easegress-io:pipeline Jun 24, 2022
@localvar localvar deleted the review-comment branch June 24, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants