Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter scheme header #634

Merged
merged 3 commits into from
Jun 28, 2022
Merged

adapter scheme header #634

merged 3 commits into from
Jun 28, 2022

Conversation

sodaRyCN
Copy link
Contributor

Some front-end proxies may modify the value of X-Forwarded-Proto, resulting in the obtained schema not meeting expectations

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #634 (3a19bfa) into main (9db3abb) will decrease coverage by 4.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
- Coverage   80.07%   75.89%   -4.19%     
==========================================
  Files          95      102       +7     
  Lines       10972    11593     +621     
==========================================
+ Hits         8786     8798      +12     
- Misses       1707     2314     +607     
- Partials      479      481       +2     
Impacted Files Coverage Δ
pkg/context/httprequest.go 19.35% <100.00%> (ø)
pkg/cluster/cluster.go 59.00% <0.00%> (-0.94%) ⬇️
pkg/context/httptemplate.go 0.00% <0.00%> (ø)
pkg/context/httpstatuscode.go 0.00% <0.00%> (ø)
pkg/context/mqttcontext.go 0.00% <0.00%> (ø)
pkg/context/httpresponse.go 0.00% <0.00%> (ø)
pkg/context/httpcontext.go 0.00% <0.00%> (ø)
pkg/context/mqttmock.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db3abb...3a19bfa. Read the comment docs.

pkg/context/httprequest.go Outdated Show resolved Hide resolved
@localvar localvar requested a review from suchen-sci June 1, 2022 06:09
@localvar localvar merged commit 4cc51ac into easegress-io:main Jun 28, 2022
@sodaRyCN sodaRyCN deleted the fix_scheme branch September 5, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants