Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit req/resp size and support stream bodies #628

Merged
merged 9 commits into from
May 19, 2022
Merged

Limit req/resp size and support stream bodies #628

merged 9 commits into from
May 19, 2022

Conversation

localvar
Copy link
Collaborator

This PR limits the request and response body size.
Support for stream bodies was also added, and several filters were refactored to aware of stream bodies.
Note that some features cannot use a stream body, as it can only be read once.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #628 (eb467a5) into pipeline (f9da7a3) will decrease coverage by 1.36%.
The diff coverage is 38.42%.

@@             Coverage Diff              @@
##           pipeline     #628      +/-   ##
============================================
- Coverage     73.57%   72.20%   -1.37%     
============================================
  Files            96       96              
  Lines         10611    10822     +211     
============================================
+ Hits           7807     7814       +7     
- Misses         2350     2528     +178     
- Partials        454      480      +26     
Impacted Files Coverage Δ
pkg/filters/proxy/memorycache.go 96.20% <0.00%> (-3.80%) ⬇️
pkg/filters/proxy/proxy.go 83.90% <ø> (ø)
pkg/filters/responseadaptor/responseadaptor.go 33.92% <0.00%> (-2.27%) ⬇️
pkg/object/httpserver/spec.go 76.00% <ø> (ø)
pkg/protocols/httpprot/http.go 100.00% <ø> (ø)
pkg/util/readers/bytecountreader.go 0.00% <0.00%> (ø)
pkg/util/readers/callbackreader.go 0.00% <0.00%> (ø)
pkg/util/readers/gzipcompressreader.go 0.00% <0.00%> (ø)
pkg/protocols/httpprot/request.go 52.72% <25.64%> (-23.80%) ⬇️
pkg/protocols/httpprot/response.go 50.00% <26.66%> (-34.89%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9da7a3...eb467a5. Read the comment docs.

@xxx7xxxx xxx7xxxx merged commit 1c329e2 into easegress-io:pipeline May 19, 2022
@localvar localvar deleted the limit-request-size branch May 25, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants