sidecar httpserver keepalive config by spec #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #626 +/- ##
==========================================
- Coverage 80.07% 80.07% -0.01%
==========================================
Files 95 95
Lines 10972 10981 +9
==========================================
+ Hits 8786 8793 +7
- Misses 1707 1709 +2
Partials 479 479
Continue to review full report at Codecov.
|
sodaRyCN
force-pushed
the
fix_sidecar_httpserver_keepalive
branch
from
4e01df5
to
b5ab1c1
Compare
sodaRyCN
force-pushed
the
fix_sidecar_httpserver_keepalive
branch
from
b5ab1c1
to
1acc60c
Compare
localvar
reviewed
May 17, 2022
localvar
approved these changes
May 17, 2022
suchen-sci
approved these changes
Jun 6, 2022
localvar
pushed a commit
that referenced
this pull request
Jun 13, 2022
* sidecar httpserver keepalive config by spec * adjust variable names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sidecar mode, the httpservers of ingress and egress load keepalive-related configurations according to the mesh-controller spec(it seems that there is no other suitable object to carry this configuration).It seems that there is no other suitable object to carry this configuration. In preliminary consideration, it is not necessary to set different parameters for each worker(if this is done, the ops would be complicated). If there is, use
--labelwould be better.