Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FaasController: Keep request host field #586

Merged
merged 5 commits into from
Apr 20, 2022

Conversation

samutamm
Copy link
Contributor

Fix #554.

  • Add new flag KeepHost to proxy.Server that overrides logic of Easegress response with 403 when a domain name is used for server URL #447 when true (by default false). This fixes FaasController that uses Host to route request to FaaS functions.
  • Update and simplify doc/reference/faascontroller.md and doc/cookboook/faas.md.
  • Describe in doc/reference/faascontroller.md another way (Magic DNS instead of Temporary DNS) to configure Knative FaasProvider.

@samutamm samutamm changed the title Fix faas docs FaasController: Keep request host field Apr 19, 2022
@samutamm samutamm requested a review from localvar April 20, 2022 01:49
@samutamm samutamm merged commit 19ff0db into easegress-io:main Apr 20, 2022
@samutamm samutamm deleted the fix-faas-docs branch April 20, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FaaSController does not set request Host as expected
3 participants