Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version to 1.17 #546

Merged
merged 8 commits into from
Mar 22, 2022
Merged

Conversation

samutamm
Copy link
Contributor

After the release of Go 1.18, it's time to update the supported go versions to 1.17 and 1.18.

  • Run go mod tidy -go=1.17 to upgrade the minimum version to 1.17
  • Update supported versions in docs

Please note that version 1.17 changes the go.mod structure and it now consist of two require blocks https://go.dev/doc/go1.17.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #546 (6b9e95c) into main (0f4c911) will decrease coverage by 0.08%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
- Coverage   78.71%   78.62%   -0.09%     
==========================================
  Files          94       94              
  Lines       10818    10798      -20     
==========================================
- Hits         8515     8490      -25     
- Misses       1819     1824       +5     
  Partials      484      484              
Impacted Files Coverage Δ
pkg/object/autocertmanager/domain.go 70.94% <70.00%> (-2.75%) ⬇️
pkg/object/autocertmanager/autocertmanager.go 93.46% <100.00%> (-0.19%) ⬇️
pkg/object/mqttproxy/client.go 79.63% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4c911...6b9e95c. Read the comment docs.

@localvar
Copy link
Collaborator

Makefile Show resolved Hide resolved
@samutamm samutamm requested a review from localvar March 21, 2022 07:40
@samutamm samutamm requested a review from localvar March 22, 2022 02:51
@samutamm samutamm merged commit 3f1c559 into easegress-io:main Mar 22, 2022
@samutamm samutamm deleted the upgrade-go-1.17 branch March 22, 2022 05:03
localvar pushed a commit that referenced this pull request Mar 29, 2022
* go mod tidy -go=1.17

* update supported go versions to 1.17 and 1.18

* upgrade go version in workflows and docs

* fix actions

* update docker builder image go version

* remove go 1.6 specific backward compatibility handling

* if cert is updated first time, store it

* avoid race conditions in initial cert update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants