Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic sidecar injection arguments #508

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

xxx7xxxx
Copy link
Contributor

Following change for megaease/easemesh#121 . Will be ready after it merged.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022

Codecov Report

Merging #508 (6e2f3aa) into main (a9c9167) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   80.58%   80.52%   -0.06%     
==========================================
  Files          87       87              
  Lines       10123    10123              
==========================================
- Hits         8158     8152       -6     
- Misses       1512     1516       +4     
- Partials      453      455       +2     
Impacted Files Coverage Δ
pkg/object/meshcontroller/spec/spec.go 86.62% <ø> (ø)
pkg/cluster/cluster.go 51.87% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c9167...6e2f3aa. Read the comment docs.

@xxx7xxxx xxx7xxxx marked this pull request as ready for review February 16, 2022 02:19
@localvar localvar merged commit 2078f02 into easegress-io:main Feb 16, 2022
@xxx7xxxx xxx7xxxx deleted the dynamic-spec branch February 25, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants