Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KVMap for MQTTContext and update Kafka filter #462

Merged
merged 3 commits into from
Jan 14, 2022
Merged

Add KVMap for MQTTContext and update Kafka filter #462

merged 3 commits into from
Jan 14, 2022

Conversation

suchen-sci
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #462 (d51abc7) into main (7548804) will decrease coverage by 0.31%.
The diff coverage is 67.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
- Coverage   80.29%   79.97%   -0.32%     
==========================================
  Files          73       73              
  Lines        8275     8321      +46     
==========================================
+ Hits         6644     6655      +11     
- Misses       1265     1297      +32     
- Partials      366      369       +3     
Impacted Files Coverage Δ
pkg/filter/kafka/kafka.go 56.73% <61.01%> (+0.27%) ⬆️
pkg/filter/topicmapper/topicmapper.go 48.64% <66.66%> (ø)
pkg/filter/connectcontrol/connectcontrol.go 96.10% <100.00%> (ø)
pkg/filter/mqttclientauth/mqttauth.go 83.56% <100.00%> (ø)
pkg/cluster/layout.go 89.47% <0.00%> (-10.53%) ⬇️
pkg/object/mqttproxy/session.go 74.23% <0.00%> (-7.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7548804...d51abc7. Read the comment docs.

pkg/filter/kafka/spec.go Show resolved Hide resolved
pkg/filter/kafka/spec.go Outdated Show resolved Hide resolved
pkg/filter/kafka/kafka.go Outdated Show resolved Hide resolved
pkg/filter/kafka/kafka.go Outdated Show resolved Hide resolved
pkg/filter/kafka/kafka.go Show resolved Hide resolved
Copy link
Collaborator

@zhao-kun zhao-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suchen-sci suchen-sci merged commit 735656a into easegress-io:main Jan 14, 2022
@suchen-sci suchen-sci deleted the update-mqttcontext branch January 26, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants