Docker: add tzdata package for latest alpine #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxx7xxxx
reviewed
Jun 18, 2021
| @@ -8,14 +8,14 @@ RUN make clean && make build | |||
|
|
|||
| # --- | |||
|
|
|||
| FROM alpine:3.13 | |||
| FROM alpine:latest | |||
There was a problem hiding this comment.
latest sounds cool, but can it guarantee stability?
There was a problem hiding this comment.
The release strategy of Alpine Linux seems promising: https://alpinelinux.org/releases/
There was a problem hiding this comment.
latest should be fine for now for our needs especially using a built golang executable. If we were using python or java on the other hand, beyond me running for the hills, we would have a much larger dependency on the libs provided by the base image
xxx7xxxx
approved these changes
Jun 19, 2021
fengyie007
pushed a commit
to fengyie007/easegress
that referenced
this pull request
Jun 21, 2021
* Docker: add tzdata package for latest alpine * Chore: remove old files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.