Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udpate integration test #442

Merged
merged 2 commits into from
Dec 27, 2021
Merged

udpate integration test #442

merged 2 commits into from
Dec 27, 2021

Conversation

suchen-sci
Copy link
Contributor

@suchen-sci suchen-sci commented Dec 27, 2021

We update example yaml last week (use new cluster version of yaml). As a result, primary-001 can not used alone for integration test since it will wait all clusters to start up. This pr update integration test to use single node primary easegress to do the test.

update github workflow, run test when change yaml file and shell file since these changes may fail integration test.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2021

Codecov Report

Merging #442 (55b3192) into main (fb7d28c) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   80.44%   80.45%   +0.01%     
==========================================
  Files          70       70              
  Lines        8094     8094              
==========================================
+ Hits         6511     6512       +1     
+ Misses       1225     1224       -1     
  Partials      358      358              
Impacted Files Coverage Δ
pkg/object/mqttproxy/client.go 77.67% <0.00%> (-2.33%) ⬇️
pkg/cluster/cluster.go 50.68% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94c87ad...55b3192. Read the comment docs.

Copy link
Contributor

@samutamm samutamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but just for reference we could also test 3 member cluster like this 85cf299

@suchen-sci
Copy link
Contributor Author

Thanks Samu, we may add that later. Test cluster may need some new tests. Objects like HTTPServer need open new port, so when run multiple easegress in one machine, some objects may failed to create.

@suchen-sci suchen-sci merged commit ffd3bdc into easegress-io:main Dec 27, 2021
@suchen-sci suchen-sci deleted the update-integration-test branch January 26, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants