Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix easegress-server keep running on invalid yaml #432

Merged
merged 6 commits into from
Dec 23, 2021
Merged

fix easegress-server keep running on invalid yaml #432

merged 6 commits into from
Dec 23, 2021

Conversation

suchen-sci
Copy link
Contributor

@suchen-sci suchen-sci commented Dec 23, 2021

This PR fix issue #431. If user provides invalid yaml, then easegress-server will report error and return.

ps: Here invalid yaml file means it provides wrong type for option. For example, option.cluster.initial-cluster has type map[string]string; if we provide an []string instead it will cause problem.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #432 (9f99afb) into main (8ae49a6) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   80.47%   80.38%   -0.10%     
==========================================
  Files          70       70              
  Lines        8093     8094       +1     
==========================================
- Hits         6513     6506       -7     
- Misses       1222     1228       +6     
- Partials      358      360       +2     
Impacted Files Coverage Δ
pkg/object/mqttproxy/broker.go 75.05% <100.00%> (+0.05%) ⬆️
pkg/cluster/cluster.go 49.65% <0.00%> (-1.03%) ⬇️
pkg/object/mqttproxy/client.go 77.67% <0.00%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae49a6...9f99afb. Read the comment docs.

@suchen-sci suchen-sci marked this pull request as draft December 23, 2021 06:48
@suchen-sci suchen-sci marked this pull request as ready for review December 23, 2021 06:59
@suchen-sci
Copy link
Contributor Author

in mqtt, we store session asynchronous. And this cause some mqtt test about session failed occasional (we check before session stored). this pr will fix them too.

@suchen-sci suchen-sci merged commit fb7d28c into easegress-io:main Dec 23, 2021
@suchen-sci suchen-sci deleted the fix-invalid-yaml-issue branch January 26, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

easegress-server not report error and return with invalid yaml config file
4 participants