Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use GitHub Actions to run tests #41

Merged
merged 1 commit into from
Jun 24, 2021
Merged

CI: use GitHub Actions to run tests #41

merged 1 commit into from
Jun 24, 2021

Conversation

Loyalsoldier
Copy link
Contributor

Run tests on macOS, Ubuntu and Windows with latest Go release using GitHub Actions triggered by:

  • push and pull request event
  • changes of files **/*.go, go.mod and go.sum

@bigangryrobot
Copy link
Contributor

This looks great. My only suggestion is that we look at the triggers a bit, as I would generally recommend using branch and tag based actions over path based

    paths:
      - "**/*.go"
      - "go.mod"
      - "go.sum"
      - ".github/workflows/test.yml"

@Loyalsoldier
Copy link
Contributor Author

@bigangryrobot Yeah, the test is triggered by push and pull request event on main branch, and the paths are just used to filter file changes that do not need to run the test, e.g. document changes.

@benja-wu benja-wu merged commit 7097e5b into easegress-io:main Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants