Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
TestCleanSession
is used to checkcleanSession
flag in MQTT. If not cleanSession, storage will store session and when client reconnect, it will see previous subscribe topics. Yesterday the test failed (very rare, less than 1/200 runs), the message say client don't see previous subscribed topic when cleanSession is set false.After careful think about code, I think the reason maybe the goroutine to store session run after we check subscribe topics. To solve this, we first make sure session have been stored in storage, then do check.