Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mqtt clean session test #396

Merged
merged 1 commit into from
Dec 6, 2021
Merged

update mqtt clean session test #396

merged 1 commit into from
Dec 6, 2021

Conversation

suchen-sci
Copy link
Contributor

@suchen-sci suchen-sci commented Dec 3, 2021

the TestCleanSession is used to check cleanSession flag in MQTT. If not cleanSession, storage will store session and when client reconnect, it will see previous subscribe topics. Yesterday the test failed (very rare, less than 1/200 runs), the message say client don't see previous subscribed topic when cleanSession is set false.
After careful think about code, I think the reason maybe the goroutine to store session run after we check subscribe topics. To solve this, we first make sure session have been stored in storage, then do check.

@codecov-commenter
Copy link

Codecov Report

Merging #396 (4f69044) into main (262061a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   80.82%   80.82%           
=======================================
  Files          60       60           
  Lines        6966     6966           
=======================================
  Hits         5630     5630           
+ Misses       1045     1044    -1     
- Partials      291      292    +1     
Impacted Files Coverage Δ
pkg/cluster/cluster.go 50.59% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262061a...4f69044. Read the comment docs.

@xxx7xxxx xxx7xxxx merged commit efd3d6a into easegress-io:main Dec 6, 2021
@suchen-sci suchen-sci deleted the mqtt-test-update branch January 26, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants