Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github workflow for HTTPServer test #356

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

samutamm
Copy link
Contributor

@samutamm samutamm commented Nov 5, 2021

Run build/test/httpserver_test.sh as a github workflow. Trigger run only when unittests succeed.

Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 356 Deploy Test Success

@localvar
Copy link
Collaborator

localvar commented Nov 8, 2021

Is it possible to not create a new workflow?
For example, add this test as a new step of the existing workflow after the unittests.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021

Codecov Report

Merging #356 (a0ca674) into main (23329d3) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   80.58%   80.45%   -0.13%     
==========================================
  Files          54       54              
  Lines        6217     6217              
==========================================
- Hits         5010     5002       -8     
- Misses        942      949       +7     
- Partials      265      266       +1     
Impacted Files Coverage Δ
pkg/object/mqttproxy/client.go 79.87% <0.00%> (-1.22%) ⬇️
pkg/cluster/cluster.go 48.76% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7ee44...a0ca674. Read the comment docs.

@samutamm samutamm merged commit fa76323 into main Nov 8, 2021
@samutamm samutamm deleted the fix/github_actions_run_httpsrv_test branch November 8, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants