remove goroutine from a test (close #347) #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megaeasex
approved these changes
Nov 4, 2021
megaeasex
approved these changes
Nov 4, 2021
samutamm
force-pushed
the
fix/issue-347
branch
from
5f52856
to
e884972
Compare
localvar
reviewed
Nov 5, 2021
megaeasex
approved these changes
Nov 5, 2021
samutamm
force-pushed
the
fix/issue-347
branch
from
f9d2fe9
to
5589dba
Compare
megaeasex
approved these changes
Nov 5, 2021
localvar
approved these changes
Nov 5, 2021
Co-authored-by: Bomin Zhang <[email protected]>
samutamm
force-pushed
the
fix/issue-347
branch
from
5589dba
to
9f0891a
Compare
suchen-sci
reviewed
Nov 5, 2021
Co-authored-by: SU Chen <[email protected]>
megaeasex
approved these changes
Nov 5, 2021
Codecov Report
@@ Coverage Diff @@
## main #353 +/- ##
==========================================
- Coverage 80.58% 80.48% -0.10%
==========================================
Files 54 54
Lines 6217 6217
==========================================
- Hits 5010 5004 -6
- Misses 942 947 +5
- Partials 265 266 +1
Continue to review full report at Codecov.
|
suchen-sci
approved these changes
Nov 5, 2021
megaeasex
approved these changes
Nov 5, 2021
zhao-kun
pushed a commit
that referenced
this pull request
Nov 8, 2021
* remove goroutine from a test (close #347) * modify http.Server.start() in mqtt_test to wait until ready * Update pkg/object/mqttproxy/mqtt_test.go Co-authored-by: Bomin Zhang <[email protected]> * Fix typo in url address Co-authored-by: SU Chen <[email protected]> * fix formatting Co-authored-by: Bomin Zhang <[email protected]> Co-authored-by: SU Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #347.
There was nondeterministic issue with http.Server creation and closing and sending messages.
To verify that test fails 0/30 runs :
and output should have only
ok's.Todo
I found new error that should be investigated
--- FAIL: TestCleanSession (0.00s) mqtt_test.go:231: topicMgr should contain topic test/cleanSession/0 when client reconnect, but got map[]