Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka Driver Upgrading & Better Makefile for WebAssembly Build #349

Merged
merged 5 commits into from
Nov 3, 2021
Merged

Kafka Driver Upgrading & Better Makefile for WebAssembly Build #349

merged 5 commits into from
Nov 3, 2021

Conversation

haoel
Copy link
Contributor

@haoel haoel commented Nov 3, 2021

  • upgrade the Kafka Driver from 1.21.1 to 1.30.0
  • New makefile target for WebAssembly build - make wasm

@haoel haoel requested a review from localvar November 3, 2021 04:23
megaeasex
megaeasex suggested changes Nov 3, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test FAILED]megaease/easegress Pull Request 349 Deploy Test failed

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021 •
edited
Loading

Codecov Report

Merging #349 (729a6e4) into main (5a95804) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #349   +/-   ##
=======================================
  Coverage   80.48%   80.48%           
=======================================
  Files          54       54           
  Lines        6217     6217           
=======================================
  Hits         5004     5004           
  Misses        947      947           
  Partials      266      266

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a95804...729a6e4. Read the comment docs.

localvar
localvar reviewed Nov 3, 2021
View reviewed changes
README.zh-CN.md Outdated Show resolved Hide resolved
@haoel @localvar
Update README.zh-CN.md
729a6e4 
Co-authored-by: Bomin Zhang <[email protected]>
megaeasex
megaeasex suggested changes Nov 3, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test FAILED]megaease/easegress Pull Request 349 Deploy Test failed

@localvar localvar merged commit eaa5b82 into easegress-io:main Nov 3, 2021
megaeasex
megaeasex approved these changes Nov 3, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 349 Deploy Test Success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localvar localvar localvar approved these changes

@megaeasex megaeasex megaeasex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haoel @codecov-commenter @localvar @megaeasex