[mesh]: Support clean external registry & add traffic controller spec status #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megaeasex
approved these changes
Oct 29, 2021
Codecov Report
@@ Coverage Diff @@
## main #324 +/- ##
==========================================
+ Coverage 80.23% 80.48% +0.24%
==========================================
Files 53 54 +1
Lines 6098 6217 +119
==========================================
+ Hits 4893 5004 +111
- Misses 943 947 +4
- Partials 262 266 +4
Continue to review full report at Codecov.
|
localvar
reviewed
Oct 29, 2021
| rs.service = service.New(superSpec) | ||
|
|
||
| if spec.CleanExternalRegistry { | ||
| go rs.cleanExternalRegistry() |
There was a problem hiding this comment.
It is possible that this goroutine executes after rs.run and rs.serviceInstanceSpecsFunc, resulting in some newly added records being deleted, will it be a problem?
There was a problem hiding this comment.
No, you can see line 97 and 108, we ignore the entries with externalRegistryName if they have.
localvar
approved these changes
Oct 29, 2021
suchen-sci
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified by the demo.