Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix high CPU usage in mesh (close #319) #322

Merged
merged 1 commit into from
Oct 28, 2021
Merged

fix high CPU usage in mesh (close #319) #322

merged 1 commit into from
Oct 28, 2021

Conversation

localvar
Copy link
Collaborator

@localvar localvar commented Oct 26, 2021

Before the change, when the register attempt (call to routine) succeeds, it enters the next iteration immediately.
The fix inserts a wait between each register attempt.

Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 322 Deploy Test Success

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #322 (915d468) into main (465736c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #322   +/-   ##
=======================================
  Coverage   80.23%   80.23%           
=======================================
  Files          53       53           
  Lines        6098     6098           
=======================================
  Hits         4893     4893           
  Misses        943      943           
  Partials      262      262           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 465736c...915d468. Read the comment docs.

@haoel
Copy link
Contributor

haoel commented Oct 27, 2021

can we explain why the CPU is high and why this fix works?

@localvar
Copy link
Collaborator Author

can we explain why the CPU is high and why this fix works?

Before the change, when the register attempt (call to routine) succeeds, it enters the next iteration immediately.
The fix inserts a wait between each register attempt.

Copy link
Contributor

@suchen-sci suchen-sci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is great! LGTM!

@xxx7xxxx xxx7xxxx merged commit 3eb5ee9 into easegress-io:main Oct 28, 2021
@localvar localvar deleted the issue-319 branch October 28, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants