update gjson to fix security issue #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megaeasex
approved these changes
Oct 26, 2021
xxx7xxxx
reviewed
Oct 26, 2021
| @@ -128,30 +105,30 @@ type ( | |||
| // 1. Based on comparison between old and new part of entry. | |||
| // 2. Based on comparison on entries with the same prefix. | |||
| Informer interface { | |||
| OnPartOfServiceSpec(serviceName string, gjsonPath GJSONPath, fn ServiceSpecFunc) error | |||
There was a problem hiding this comment.
Why delete them instead of just updating the vendor?
There was a problem hiding this comment.
they are not used, so I remove the dependency from informer.
Codecov Report
@@ Coverage Diff @@
## main #321 +/- ##
=======================================
Coverage 80.23% 80.23%
=======================================
Files 53 53
Lines 6098 6098
=======================================
Hits 4893 4893
Misses 943 943
Partials 262 262 Continue to review full report at Codecov.
|
xxx7xxxx
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.