Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mesh] fix spec test warning and refactor certmananger #318

Merged
merged 2 commits into from
Oct 23, 2021
Merged

[mesh] fix spec test warning and refactor certmananger #318

merged 2 commits into from
Oct 23, 2021

Conversation

benja-wu
Copy link
Contributor

@benja-wu benja-wu commented Oct 22, 2021 •
edited
Loading

  1. For fixing GitHub code analysis warnings:
pkg/object/meshcontroller/spec/spec_test.go#L40
should omit type string from declaration of var RootCertBase64; it will be inferred from the right-hand side
  1. Refactoring cermanager for single goroutine.

megaeasex
megaeasex approved these changes Oct 22, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 318 Deploy Test Success

megaeasex
megaeasex approved these changes Oct 22, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 318 Deploy Test Success

@benja-wu benja-wu changed the title [mesh] fix spec test warning [mesh] fix spec test warning and refactor certmananger Oct 22, 2021
xxx7xxxx
xxx7xxxx approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@xxx7xxxx xxx7xxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A long night, thx

megaeasex
megaeasex approved these changes Oct 22, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 318 Deploy Test Success

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021 •
edited
Loading

Codecov Report

Merging #318 (db30375) into main (c6a3d76) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   80.23%   80.23%           
=======================================
  Files          53       53           
  Lines        6098     6098           
=======================================
  Hits         4893     4893           
  Misses        943      943           
  Partials      262      262

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a3d76...db30375. Read the comment docs.

@localvar localvar merged commit 101c34d into easegress-io:main Oct 23, 2021
@benja-wu benja-wu deleted the fix branch October 23, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localvar localvar localvar approved these changes

@xxx7xxxx xxx7xxxx xxx7xxxx approved these changes

@megaeasex megaeasex megaeasex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@benja-wu @codecov-commenter @localvar @xxx7xxxx @megaeasex