Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve docker image build speed #306

Merged
merged 3 commits into from
Oct 18, 2021
Merged

improve docker image build speed #306

merged 3 commits into from
Oct 18, 2021

Conversation

localvar
Copy link
Collaborator

@localvar localvar commented Oct 18, 2021 •
edited
Loading

  • use dedicated golang image as compiler
  • avoid copying source code
  • avoid downloading dependencies
  • enable golang build cache
  • avoid scan large folders

@localvar @megaeasedemo
improve docker image build speed
01e4a34 
* use dedicated golang image as compiler
* avoid copying source code
* avoid downloading dependencies
* enable golang build cache
megaeasex
megaeasex approved these changes Oct 18, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 306 Deploy Test Success

@localvar localvar marked this pull request as draft October 18, 2021 01:51
megaeasex
megaeasex approved these changes Oct 18, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 306 Deploy Test Success

megaeasex
megaeasex approved these changes Oct 18, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 306 Deploy Test Success

@localvar localvar marked this pull request as ready for review October 18, 2021 04:15
megaeasex
megaeasex approved these changes Oct 18, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 306 Deploy Test Success

@localvar localvar merged commit 78c95cb into easegress-io:main Oct 18, 2021
@localvar localvar deleted the improve-docker-build-speed branch October 18, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxx7xxxx xxx7xxxx xxx7xxxx approved these changes

@megaeasex megaeasex megaeasex approved these changes

@suchen-sci suchen-sci suchen-sci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@localvar @xxx7xxxx @megaeasex @suchen-sci