Add some missed operations of Mesh #288
Conversation
Codecov Report
@@ Coverage Diff @@
## main #288 +/- ##
=======================================
Coverage 80.18% 80.18%
=======================================
Files 44 44
Lines 4865 4865
=======================================
Hits 3901 3901
Misses 742 742
Partials 222 222
Continue to review full report at Codecov.
|
| IngressPort: 13001, | ||
| IngressProtocol: "http", | ||
| EgressPort: 13002, |
There was a problem hiding this comment.
IngressPort & EgressPort are hardcoded to 13001 & 13002, just to confirm this is desired.
There was a problem hiding this comment.
These are external services, so I think we should assign an default IngressPort and EgressPort for them, for keeping other parts going well.
There was a problem hiding this comment.
There are no constants in Easegress repo, so I used the default EaseMesh ports.
| IngressPort: 13001, | ||
| IngressProtocol: "http", | ||
| EgressPort: 13002, |
There was a problem hiding this comment.
These are external services, so I think we should assign an default IngressPort and EgressPort for them, for keeping other parts going well.
| @@ -126,6 +126,7 @@ func (rcs *Server) DiscoveryService(serviceName string) (*ServiceRegistryInfo, e | |||
| return serviceInfo, err | |||
| } | |||
|
|
|||
| // FIXME: rcs.tenant won't change after updating | |||
There was a problem hiding this comment.
This problem had been fixed in PR #287
Enhancement stuff in preparation of demo