Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance tuning #277

Merged
merged 10 commits into from
Oct 29, 2021
Merged

performance tuning #277

merged 10 commits into from
Oct 29, 2021

Conversation

localvar
Copy link
Collaborator

@localvar localvar commented Sep 25, 2021 •
edited
Loading

too many files are modified, propose to review commit by commit, this could make the review process easier.

megaeasex
megaeasex approved these changes Sep 25, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 277 Deploy Test Success

megaeasex
megaeasex approved these changes Sep 25, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 277 Deploy Test Success

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021 •
edited
Loading

Codecov Report

Merging #277 (cf0536e) into main (96dd37d) will increase coverage by 0.24%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   80.23%   80.48%   +0.24%     
==========================================
  Files          53       54       +1     
  Lines        6098     6217     +119     
==========================================
+ Hits         4893     5004     +111     
- Misses        943      947       +4     
- Partials      262      266       +4
Impacted Files Coverage Δ
pkg/util/fasttime/fasttime_unix.go 100.00% <ø> (ø)
pkg/filter/proxy/pool.go 82.65% <70.00%> (-1.37%) ⬇️
pkg/filter/proxy/request.go 85.71% <80.00%> (ø)
pkg/util/fasttime/fasttime.go 94.73% <94.73%> (ø)
pkg/filter/circuitbreaker/circuitbreaker.go 92.35% <100.00%> (ø)
pkg/object/meshcontroller/spec/spec.go 86.95% <0.00%> (ø)
pkg/util/timetool/distributedtimer.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96dd37d...cf0536e. Read the comment docs.

@haoel haoel added the enhancement New feature or request label Oct 14, 2021
megaeasex
megaeasex approved these changes Oct 20, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 277 Deploy Test Success

megaeasex
megaeasex approved these changes Oct 20, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 277 Deploy Test Success

@localvar localvar changed the title performance tuning (step 1) performance tuning Oct 20, 2021
megaeasex
megaeasex approved these changes Oct 20, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 277 Deploy Test Success

@localvar localvar marked this pull request as draft October 20, 2021 07:44
@localvar localvar marked this pull request as ready for review October 24, 2021 09:48
@localvar localvar requested review from haoel and zhao-kun and removed request for benja-wu October 25, 2021 02:26
haoel
haoel reviewed Oct 27, 2021
View reviewed changes
pkg/util/fasttime/fasttime.go Outdated Show resolved Hide resolved
pkg/util/fasttime/fasttime.go Show resolved Hide resolved
pkg/util/fasttime/fasttime.go Show resolved Hide resolved
pkg/util/fasttime/fasttime.go Show resolved Hide resolved
megaeasex
megaeasex approved these changes Oct 27, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 277 Deploy Test Success

haoel
haoel approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@haoel haoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. let's merge this early, then tunning the next one.

@haoel haoel merged commit 332a230 into easegress-io:main Oct 29, 2021
@localvar localvar deleted the perf branch October 29, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoel haoel haoel approved these changes

@megaeasex megaeasex megaeasex approved these changes

@suchen-sci suchen-sci suchen-sci approved these changes

@xxx7xxxx xxx7xxxx Awaiting requested review from xxx7xxxx

@zhao-kun zhao-kun Awaiting requested review from zhao-kun

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@localvar @codecov-commenter @haoel @megaeasex @suchen-sci