fix lint warning #242
Merged
fix lint warning #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type *command.streamVisitor, which can be annoying to use
megaeasex
approved these changes
Sep 7, 2021
megaeasex
approved these changes
Sep 7, 2021
Codecov Report
@@ Coverage Diff @@
## main #242 +/- ##
=======================================
Coverage 80.12% 80.12%
=======================================
Files 44 44
Lines 4835 4835
=======================================
Hits 3874 3874
Misses 740 740
Partials 221 221
Continue to review full report at Codecov.
|
megaeasex
approved these changes
Sep 7, 2021
localvar
approved these changes
Sep 7, 2021
xmh19936688
pushed a commit
to xmh19936688/easegress
that referenced
this pull request
Sep 13, 2021
* fix lint warning - exported func NewStreamVisitor returns unexported type *command.streamVisitor, which can be annoying to use * add comment for StreamVisitor struct * golang 1.17 : go:build style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exported func NewStreamVisitor returns unexported type *command.streamVisitor, which can be annoying to usego:buildline