Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example typo #236

Merged
merged 2 commits into from
Sep 3, 2021
Merged

example typo #236

merged 2 commits into from
Sep 3, 2021

Conversation

suchen-sci
Copy link
Contributor

@suchen-sci suchen-sci commented Sep 3, 2021 •
edited
Loading

No description provided.

@benja-wu benja-wu added the documentation Improvements or additions to documentation label Sep 3, 2021
@benja-wu benja-wu added this to the v1.3.0 milestone Sep 3, 2021
benja-wu
benja-wu approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@benja-wu benja-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

megaeasex
megaeasex approved these changes Sep 3, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 236 Deploy Test Success

megaeasex
megaeasex approved these changes Sep 3, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 236 Deploy Test Success

@suchen-sci suchen-sci merged commit 767eb6d into easegress-io:main Sep 3, 2021
xmh19936688 pushed a commit to xmh19936688/easegress that referenced this pull request Sep 13, 2021
@suchen-sci @xmh19936688
example typo (easegress-io#236)
1d9fbf0 
* example README use clean_eg_cluster.sh but there are only clean_cluster.sh

* no kind of Function, there are FaaSController
@suchen-sci suchen-sci deleted the example-typo branch September 26, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megaeasex megaeasex megaeasex approved these changes

@localvar localvar localvar approved these changes

@benja-wu benja-wu Awaiting requested review from benja-wu

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@suchen-sci @localvar @benja-wu @megaeasex