Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add host functions for cluster data (flash sale support) #188

Merged
merged 9 commits into from
Aug 31, 2021
Merged

add host functions for cluster data (flash sale support) #188

merged 9 commits into from
Aug 31, 2021

Conversation

localvar
Copy link
Collaborator

add host functions for accessing shared cluster data.
add cookbook for flash sale.
other enhancement.

Too many files are modified, propose to review commit by commit.

@localvar localvar added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 14, 2021
@localvar localvar added this to the v1.3.0 milestone Aug 14, 2021
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 188 Deploy Test Success

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2021

Codecov Report

Merging #188 (a77e3b7) into main (7b3f92d) will decrease coverage by 1.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   81.20%   80.12%   -1.08%     
==========================================
  Files          44       44              
  Lines        4846     4835      -11     
==========================================
- Hits         3935     3874      -61     
- Misses        694      740      +46     
- Partials      217      221       +4     
Impacted Files Coverage Δ
pkg/cluster/op.go 63.79% <57.14%> (-0.43%) ⬇️
pkg/cluster/layout.go 100.00% <100.00%> (ø)
pkg/filter/proxy/server.go 70.58% <0.00%> (-23.66%) ⬇️
pkg/cluster/cluster.go 48.76% <0.00%> (-1.41%) ⬇️
pkg/object/meshcontroller/spec/spec.go 89.47% <0.00%> (-0.56%) ⬇️
pkg/filter/proxy/proxy.go 84.50% <0.00%> (-0.22%) ⬇️
pkg/filter/proxy/pool.go 84.02% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd7b96...a77e3b7. Read the comment docs.

Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 188 Deploy Test Success

Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 188 Deploy Test Success

Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 188 Deploy Test Success

@localvar localvar changed the title add host functions for cluster data add host functions for cluster data (flash sale support) Aug 27, 2021
doc/cookbook/flash_sale.md Outdated Show resolved Hide resolved
doc/cookbook/flash_sale.md Outdated Show resolved Hide resolved
pkg/api/wasm.go Show resolved Hide resolved
pkg/cluster/op.go Show resolved Hide resolved
pkg/filter/wasmhost/vm.go Show resolved Hide resolved
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 188 Deploy Test Success

Copy link
Contributor

@benja-wu benja-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benja-wu benja-wu merged commit e1d0a82 into easegress-io:main Aug 31, 2021
xmh19936688 pushed a commit to xmh19936688/easegress that referenced this pull request Sep 13, 2021
…o#188)

* add pipeline name to filter

* add host functions for cluster data

* add APIs for wasm cluster data

* update document

* revise host functions to allow zeros in string

* improve test coverage

* fix typo

* revert 1st commit, pass pipeline through meta data

* updated according to comments
@localvar localvar deleted the flash-sale branch September 14, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants