Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typo] fix typo in comments & const value(SignalUsr2) #181

Merged
merged 5 commits into from
Aug 10, 2021
Merged

[typo] fix typo in comments & const value(SignalUsr2) #181

merged 5 commits into from
Aug 10, 2021

Conversation

jxd134
Copy link
Contributor

@jxd134 jxd134 commented Aug 10, 2021

No description provided.

megaeasex
megaeasex approved these changes Aug 10, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 181 Deploy Test Success

@benja-wu benja-wu self-requested a review August 10, 2021 07:11
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021 •
edited
Loading

Codecov Report

Merging #181 (808fa1d) into main (7b3f92d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   81.20%   81.20%           
=======================================
  Files          44       44           
  Lines        4846     4846           
=======================================
  Hits         3935     3935           
  Misses        694      694           
  Partials      217      217
Impacted Files Coverage Δ
pkg/common/signal_unix.go 100.00% <ø> (ø)
pkg/filter/proxy/server.go 94.24% <ø> (ø)
pkg/util/sem/semaphore.go 90.90% <ø> (ø)
pkg/filter/proxy/pool.go 83.53% <100.00%> (ø)
pkg/util/circuitbreaker/circuitbreaker.go 81.85% <100.00%> (ø)
pkg/util/texttemplate/texttemplate.go 91.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd7b96...808fa1d. Read the comment docs.

@benja-wu benja-wu requested a review from localvar August 10, 2021 07:17
@benja-wu benja-wu added the enhancement New feature or request label Aug 10, 2021
@benja-wu benja-wu added this to In progress in Easegress Project via automation Aug 10, 2021
@benja-wu benja-wu added this to the v1.3.0 milestone Aug 10, 2021
megaeasex
megaeasex approved these changes Aug 10, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 181 Deploy Test Success

megaeasex
megaeasex approved these changes Aug 10, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 181 Deploy Test Success

megaeasex
megaeasex approved these changes Aug 10, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 181 Deploy Test Success

Easegress Project automation moved this from In progress to Reviewer approved Aug 10, 2021
benja-wu
benja-wu approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@benja-wu benja-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haoel
Copy link
Contributor

haoel commented Aug 10, 2021

@jxd134

Thanks for this PR.

And we have another misspelled word found by https://goreportcard.com/report/github.com/megaease/easegress

Could you please help correct them in this PR?

easegress/pkg/util/jmxtool/agent_controller_test.go
Line 128: warning: "shoudl" is a misspelling of "should" (misspell)
Line 132: warning: "shoudl" is a misspelling of "should" (misspell)

@jxd134
Copy link
Contributor Author

jxd134 commented Aug 10, 2021

@jxd134

Thanks for this PR.

And we have another misspelled word found by https://goreportcard.com/report/github.com/megaease/easegress

Could you please help correct them in this PR?

easegress/pkg/util/jmxtool/agent_controller_test.go
Line 128: warning: "shoudl" is a misspelling of "should" (misspell)
Line 132: warning: "shoudl" is a misspelling of "should" (misspell)

no porblem

megaeasex
megaeasex approved these changes Aug 10, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 181 Deploy Test Success

@haoel haoel merged commit ef15ab7 into easegress-io:main Aug 10, 2021
Easegress Project automation moved this from Reviewer approved to Done Aug 10, 2021
@jxd134 jxd134 deleted the typo-fix branch August 10, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localvar localvar localvar approved these changes

@benja-wu benja-wu benja-wu approved these changes

@megaeasex megaeasex megaeasex approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Easegress Project
Done
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jxd134 @codecov-commenter @haoel @localvar @benja-wu @megaeasex @jxd1990