Support bi-directional service registry controllers #171

xxx7xxxx · 2021-08-08T09:19:18Z

It's a draft for now. The framework and driver are done, it left a dedicated registry syncer for mesh and integration test to do.

megaeasex

[TASK:easegress-pr-test FAILED]megaease/easegress Pull Request 171 Deploy Test failed

megaeasex

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

codecov-commenter · 2021-08-08T09:25:34Z

Codecov Report

Merging #171 (ed0cb5d) into main (6b08bc7) will decrease coverage by 1.05%.
The diff coverage is 56.66%.

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   81.20%   80.14%   -1.06%     
==========================================
  Files          44       44              
  Lines        4846     4826      -20     
==========================================
- Hits         3935     3868      -67     
- Misses        694      738      +44     
- Partials      217      220       +3

Impacted Files	Coverage Δ
pkg/object/meshcontroller/spec/spec.go	`89.47% <0.00%> (-0.56%)`	⬇️
pkg/cluster/cluster.go	`48.76% <25.00%> (-1.41%)`	⬇️
pkg/filter/proxy/server.go	`70.58% <50.00%> (-23.66%)`	⬇️
pkg/filter/proxy/pool.go	`84.02% <85.71%> (+0.48%)`	⬆️
pkg/filter/proxy/proxy.go	`84.50% <100.00%> (-0.22%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b08bc7...ed0cb5d. Read the comment docs.

megaeasex

[TASK:easegress-pr-test FAILED]megaease/easegress Pull Request 171 Deploy Test failed

megaeasex

[TASK:easegress-pr-test FAILED]megaease/easegress Pull Request 171 Deploy Test failed

megaeasex

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

doc/controllers.md

pkg/object/consulserviceregistry/consulserviceregistry.go

pkg/object/etcdserviceregistry/etcdserviceregistry.go

pkg/object/eurekaserviceregistry/eurekaserviceregistry.go

pkg/object/nacosserviceregistry/nacosserviceregistry.go

pkg/object/zookeeperserviceregistry/zookeeperserviceregistry.go

xxx7xxxx · 2021-08-27T03:39:50Z

Updated as comments

megaeasex

[TASK:easegress-pr-test FAILED]megaease/easegress Pull Request 171 Deploy Test failed

pkg/filter/proxy/server.go

pkg/object/consulserviceregistry/client.go

pkg/object/consulserviceregistry/consulserviceregistry.go

megaeasex

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

benja-wu

LGTM

* [mesh]: Support bi-directional service registry controllers * [mesh]: Add vendor * [mesh]: Support nacos service registry * [mesh]: Complete mesh registry syncer * [mesh]: Use mutex pointer to copy * [mesh]: Add more checking * [doc]: Add NacosServiceRegistry * [doc]: Add more document * [mesh]: Add leader judgement for syncing * [proxy]: Add dynamic service test * [proxy]: Fix data race warning && Add service registry document * Fix unit test * Fix mod * Fix close client in service registry drivers * use a better name for dynamic servers

megaeasex suggested changes Aug 8, 2021

View reviewed changes

megaeasex approved these changes Aug 8, 2021

View reviewed changes

xxx7xxxx force-pushed the mesh branch from d96d19f to 74a5fd2 Compare August 15, 2021 09:26

megaeasex suggested changes Aug 15, 2021

View reviewed changes

xxx7xxxx force-pushed the mesh branch from 2e7a844 to ae4adcc Compare August 15, 2021 16:13

megaeasex suggested changes Aug 15, 2021

View reviewed changes

megaeasex approved these changes Aug 15, 2021

View reviewed changes

xxx7xxxx marked this pull request as ready for review August 15, 2021 16:17

megaeasex approved these changes Aug 19, 2021

View reviewed changes

megaeasex approved these changes Aug 20, 2021

View reviewed changes

benja-wu requested review from localvar and benja-wu August 24, 2021 02:30

benja-wu added the enhancement New feature or request label Aug 24, 2021

benja-wu added this to the v1.3.0 milestone Aug 24, 2021

benja-wu added this to In progress in Easegress Project via automation Aug 24, 2021

xxx7xxxx force-pushed the mesh branch from f9aeeee to 05ebb8a Compare August 24, 2021 03:31

megaeasex approved these changes Aug 24, 2021

View reviewed changes

xxx7xxxx force-pushed the mesh branch from e17e648 to 54be196 Compare August 25, 2021 02:58

megaeasex approved these changes Aug 25, 2021

View reviewed changes

localvar reviewed Aug 27, 2021

View reviewed changes

Easegress Project automation moved this from In progress to Reviewer approved Aug 27, 2021

localvar approved these changes Aug 27, 2021

View reviewed changes

Easegress Project automation moved this from Reviewer approved to Review in progress Aug 27, 2021

megaeasex suggested changes Aug 27, 2021

View reviewed changes

benja-wu reviewed Aug 27, 2021

View reviewed changes

pkg/filter/proxy/server.go Outdated Show resolved Hide resolved

pkg/object/consulserviceregistry/client.go Show resolved Hide resolved

pkg/object/consulserviceregistry/consulserviceregistry.go Show resolved Hide resolved

xxx7xxxx added 14 commits August 27, 2021 12:38

[mesh]: Support bi-directional service registry controllers

70b4f38

[mesh]: Add vendor

373a05a

[mesh]: Support nacos service registry

a7f5d17

[mesh]: Complete mesh registry syncer

c03107f

[mesh]: Use mutex pointer to copy

80b8ccc

[mesh]: Add more checking

01be483

[doc]: Add NacosServiceRegistry

3b10385

[doc]: Add more document

0bf54fb

[mesh]: Add leader judgement for syncing

0416ac0

[proxy]: Add dynamic service test

d1f998d

[proxy]: Fix data race warning && Add service registry document

fd294e7

Fix unit test

78be883

Fix mod

5fcd28a

Fix close client in service registry drivers

2031a45

xxx7xxxx force-pushed the mesh branch from 8d12242 to 2031a45 Compare August 27, 2021 04:39

Easegress Project automation moved this from Review in progress to Reviewer approved Aug 27, 2021

megaeasex approved these changes Aug 27, 2021

View reviewed changes

use a better name for dynamic servers

ed0cb5d

megaeasex approved these changes Aug 27, 2021

View reviewed changes

benja-wu approved these changes Aug 27, 2021

View reviewed changes

benja-wu merged commit 91319d2 into easegress-io:main Aug 27, 2021

Easegress Project automation moved this from Reviewer approved to Done Aug 27, 2021

xxx7xxxx deleted the mesh branch September 12, 2021 12:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support bi-directional service registry controllers #171

Support bi-directional service registry controllers #171

xxx7xxxx commented Aug 8, 2021 •

edited

Loading

megaeasex left a comment

megaeasex left a comment

codecov-commenter commented Aug 8, 2021 •

edited

Loading

megaeasex left a comment

megaeasex left a comment

megaeasex left a comment

megaeasex left a comment

megaeasex left a comment

megaeasex left a comment

megaeasex left a comment

megaeasex left a comment

megaeasex left a comment

megaeasex left a comment

megaeasex left a comment

megaeasex left a comment

xxx7xxxx commented Aug 27, 2021

megaeasex left a comment

megaeasex left a comment

megaeasex left a comment

benja-wu left a comment

Support bi-directional service registry controllers #171

Support bi-directional service registry controllers #171

Conversation

xxx7xxxx commented Aug 8, 2021 • edited Loading

megaeasex left a comment

Choose a reason for hiding this comment

megaeasex left a comment

Choose a reason for hiding this comment

codecov-commenter commented Aug 8, 2021 • edited Loading

Codecov Report

megaeasex left a comment

Choose a reason for hiding this comment

megaeasex left a comment

Choose a reason for hiding this comment

megaeasex left a comment

Choose a reason for hiding this comment

megaeasex left a comment

Choose a reason for hiding this comment

megaeasex left a comment

Choose a reason for hiding this comment

megaeasex left a comment

Choose a reason for hiding this comment

megaeasex left a comment

Choose a reason for hiding this comment

megaeasex left a comment

Choose a reason for hiding this comment

megaeasex left a comment

Choose a reason for hiding this comment

megaeasex left a comment

Choose a reason for hiding this comment

megaeasex left a comment

Choose a reason for hiding this comment

megaeasex left a comment

Choose a reason for hiding this comment

xxx7xxxx commented Aug 27, 2021

megaeasex left a comment

Choose a reason for hiding this comment

megaeasex left a comment

Choose a reason for hiding this comment

megaeasex left a comment

Choose a reason for hiding this comment

benja-wu left a comment

Choose a reason for hiding this comment

xxx7xxxx commented Aug 8, 2021 •

edited

Loading

codecov-commenter commented Aug 8, 2021 •

edited

Loading