Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chores] remove unnecessary files and add texttemplate test #139

Merged
merged 2 commits into from
Jul 21, 2021
Merged

[chores] remove unnecessary files and add texttemplate test #139

merged 2 commits into from
Jul 21, 2021

Conversation

benja-wu
Copy link
Contributor

  1. Remove mesh-related CTL files
  2. Remove common/go.go and common/option.go and test files.
  3. Add texttemplate go test.
  • local coverage rate raise from
    total: (statements) 61.8%
    to
    total: (statements) 62.3%

@benja-wu benja-wu added the dependencies Pull requests that update a dependency file label Jul 21, 2021
@benja-wu benja-wu added this to the v1.2.0 milestone Jul 21, 2021
@benja-wu benja-wu added this to In progress in Easegress Project via automation Jul 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #139 (f6ba950) into main (56b55b0) will increase coverage by 11.97%.
The diff coverage is 68.08%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #139       +/-   ##
===========================================
+ Coverage   46.48%   58.45%   +11.97%     
===========================================
  Files          38       36        -2     
  Lines        2590     2477      -113     
===========================================
+ Hits         1204     1448      +244     
+ Misses       1305      924      -381     
- Partials       81      105       +24     
Impacted Files Coverage Δ
pkg/common/lazybuf.go 68.75% <ø> (+68.75%) ⬆️
pkg/common/os.go 0.00% <ø> (ø)
pkg/common/sample.go 0.00% <0.00%> (ø)
pkg/common/stat_aggregator.go 65.48% <0.00%> (+3.53%) ⬆️
pkg/common/sys_proc_linux.go 0.00% <ø> (ø)
pkg/common/sys_proc_others.go 0.00% <ø> (ø)
pkg/common/time.go 100.00% <ø> (+100.00%) ⬆️
pkg/common/uuid.go 71.42% <ø> (+71.42%) ⬆️
pkg/object/function/spec/fsm.go 94.44% <ø> (ø)
pkg/object/function/spec/function.go 44.00% <ø> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5770893...f6ba950. Read the comment docs.

Easegress Project automation moved this from In progress to Reviewer approved Jul 21, 2021
@localvar localvar merged commit 2b4a6dc into easegress-io:main Jul 21, 2021
Easegress Project automation moved this from Reviewer approved to Done Jul 21, 2021
@benja-wu benja-wu deleted the chores branch August 12, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants