Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supply some unit tests to increase the code coverage #133

Merged
merged 11 commits into from
Jul 19, 2021
Merged

supply some unit tests to increase the code coverage #133

merged 11 commits into from
Jul 19, 2021

Conversation

haoel
Copy link
Contributor

@haoel haoel commented Jul 18, 2021

The unit tests for

  • pkg/util/ratelimiter
  • pkg/util/circuitbreaker
  • pkg/util/agent_controller
  • pkg/util/texttemplate
  • pkg/common/utils
  • pkg/common/strings
  • pkg/common/options
  • pkg/common/time
  • pkg/common/stat_aggregator
  • pkg/common/go
  • pkg/common/callback

… circuitbreaker, agent_controller, texttemplate
@haoel haoel requested review from localvar and benja-wu July 18, 2021 05:14
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2021

Codecov Report

Merging #133 (7b1970d) into main (f941a2c) will increase coverage by 13.07%.
The diff coverage is 59.37%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #133       +/-   ##
===========================================
+ Coverage   46.55%   59.63%   +13.07%     
===========================================
  Files          38       38               
  Lines        2586     2601       +15     
===========================================
+ Hits         1204     1551      +347     
+ Misses       1302      940      -362     
- Partials       80      110       +30     
Impacted Files Coverage Δ
pkg/common/stat_aggregator.go 65.48% <0.00%> (+3.53%) ⬆️
pkg/util/jmxtool/agent_controller.go 48.88% <35.71%> (+48.88%) ⬆️
pkg/util/circuitbreaker/circuitbreaker.go 79.50% <90.90%> (+16.61%) ⬆️
pkg/util/ratelimiter/ratelimiter.go 89.65% <100.00%> (+30.00%) ⬆️
pkg/util/texttemplate/texttemplate.go 75.83% <0.00%> (+4.69%) ⬆️
pkg/util/jmxtool/common.go 69.81% <0.00%> (+20.75%) ⬆️
pkg/util/urlrule/urlrule.go 82.50% <0.00%> (+35.00%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f941a2c...7b1970d. Read the comment docs.

@haoel haoel changed the title supply come unit tests to increase the code coverage supply some unit tests to increase the code coverage Jul 18, 2021
@benja-wu benja-wu added the enhancement New feature or request label Jul 18, 2021
@benja-wu benja-wu added this to In progress in Easegress Project via automation Jul 18, 2021
@benja-wu benja-wu added this to the v1.2.0 milestone Jul 18, 2021
Copy link
Contributor

@benja-wu benja-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/common/go_test.go Outdated Show resolved Hide resolved
pkg/common/callback_test.go Outdated Show resolved Hide resolved
pkg/common/time_test.go Show resolved Hide resolved
pkg/common/option_test.go Outdated Show resolved Hide resolved
pkg/util/circuitbreaker/circuitbreaker.go Outdated Show resolved Hide resolved
pkg/util/jmxtool/agent_controller_test.go Outdated Show resolved Hide resolved
Easegress Project automation moved this from In progress to Reviewer approved Jul 19, 2021
@benja-wu benja-wu merged commit a425a49 into easegress-io:main Jul 19, 2021
Easegress Project automation moved this from Reviewer approved to Done Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants