Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action for code analysis & fix the spelling & lint issues #132

Merged
merged 8 commits into from
Jul 17, 2021
Merged

Conversation

haoel
Copy link
Contributor

@haoel haoel commented Jul 17, 2021

  • Add the github action for code analysis

    • revive lint
    • go code formation
    • miss spelling
  • Fix some code lint issues

@haoel haoel requested a review from benja-wu July 17, 2021 05:02
@haoel haoel changed the title Add github action for code analysis Add github action for code analysis & fix the spelling & lint issues Jul 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #132 (3f7fe9e) into main (d36e20d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   46.55%   46.55%           
=======================================
  Files          38       38           
  Lines        2586     2586           
=======================================
  Hits         1204     1204           
  Misses       1302     1302           
  Partials       80       80           
Impacted Files Coverage Δ
pkg/object/function/spec/fsm.go 94.44% <ø> (ø)
pkg/util/circuitbreaker/circuitbreaker.go 62.89% <ø> (ø)
pkg/util/jmxtool/jmx_controller.go 54.54% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d36e20d...3f7fe9e. Read the comment docs.

@benja-wu benja-wu added the enhancement New feature or request label Jul 17, 2021
@benja-wu benja-wu added this to In progress in Easegress Project via automation Jul 17, 2021
@benja-wu benja-wu added this to the v1.2.0 milestone Jul 17, 2021
Copy link
Contributor

@benja-wu benja-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benja-wu benja-wu requested a review from localvar July 17, 2021 05:41
Easegress Project automation moved this from In progress to Reviewer approved Jul 17, 2021
@localvar localvar merged commit f941a2c into easegress-io:main Jul 17, 2021
Easegress Project automation moved this from Reviewer approved to Done Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants