Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace megaease links to easegress-io #1237

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

xxx7xxxx
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.67%. Comparing base (49fda2d) to head (9ad1e09).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
+ Coverage   79.62%   79.67%   +0.05%     
==========================================
  Files         152      152              
  Lines       17228    17228              
==========================================
+ Hits        13717    13726       +9     
+ Misses       2849     2841       -8     
+ Partials      662      661       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xxx7xxxx
Copy link
Contributor Author

xxx7xxxx commented Mar 10, 2024

Some integration tests failed with the message:

go: github.com/easegress-io/easegress/v2@upgrade (v2.7.1) requires github.com/easegress-io/easegress/[email protected]: parsing go.mod:
        module declares its path as: github.com/megaease/easegress/v2
                but was required as: github.com/easegress-io/easegress/v2
Error: exec 0x1034bd870 failed, exit status 1

So it's a deadlock-like situation, so we decided not to change the import paths currently since Golang module redirection works badly.

@suchen-sci suchen-sci added this pull request to the merge queue Mar 10, 2024
Merged via the queue into easegress-io:main with commit 051079d Mar 10, 2024
10 checks passed
@xxx7xxxx xxx7xxxx deleted the replace-megaease branch March 10, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants