Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty proxy-timeout failure #1236

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

xxx7xxxx
Copy link
Contributor

@xxx7xxxx xxx7xxxx commented Mar 9, 2024

In my last test case, there is always the annotation easegress.ingress.kubernetes.io/proxy-timeout, so it didn't fail. But it will fail if there isn't. It may fix the issue #1215 and #1235

@xxx7xxxx xxx7xxxx requested a review from suchen-sci March 9, 2024 04:57
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.63%. Comparing base (907f3f5) to head (83addd0).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
+ Coverage   79.62%   79.63%   +0.01%     
==========================================
  Files         152      152              
  Lines       17228    17228              
==========================================
+ Hits        13718    13720       +2     
+ Misses       2847     2845       -2     
  Partials      663      663              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suchen-sci suchen-sci added this pull request to the merge queue Mar 9, 2024
Merged via the queue into easegress-io:main with commit 49fda2d Mar 9, 2024
10 checks passed
@xxx7xxxx xxx7xxxx deleted the ingress branch March 9, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants