Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix AutoCertManager delete duplicate records #1198

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

suchen-sci
Copy link
Contributor

Previously, the AutoCertManager used the Name and Type attributes to delete DNS records before appending new ones. However, this approach encountered issues with providers like DNSPod, which require an ID for record deletion. This limitation led to the accumulation of obsolete records at the DNS provider, eventually causing errors.

This pull request addresses the problem by modifying AutoCertManager to delete DNS records using their IDs instead of Name and Type. This change ensures compatibility with providers like DNSPod that rely on ID-based deletion.

To aid in future debugging and to preemptively handle unexpected scenarios, additional logging has been integrated into the process of deleting and appending records.

@suchen-sci suchen-sci changed the title Autocert del fix AutoCertManager delete duplicate records Jan 22, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (2aa5400) 79.84% compared to head (94a290a) 79.70%.

Files Patch % Lines
pkg/object/autocertmanager/domain.go 20.00% 23 Missing and 5 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1198      +/-   ##
==========================================
- Coverage   79.84%   79.70%   -0.14%     
==========================================
  Files         152      152              
  Lines       17163    17196      +33     
==========================================
+ Hits        13703    13706       +3     
- Misses       2805     2830      +25     
- Partials      655      660       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xxx7xxxx xxx7xxxx added this pull request to the merge queue Jan 22, 2024
Merged via the queue into easegress-io:main with commit 6906af7 Jan 22, 2024
8 checks passed
@suchen-sci suchen-sci deleted the autocert-del branch January 22, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants