support egctl get describe different namespace #1197
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1197 +/- ##
==========================================
- Coverage 79.84% 79.72% -0.12%
==========================================
Files 152 152
Lines 17163 17196 +33
==========================================
+ Hits 13703 13709 +6
- Misses 2805 2828 +23
- Partials 655 659 +4 ☔ View full report in Codecov by Sentry. |
…ery status of non-traffic object
suchen-sci
changed the title
| return res, nil | ||
| } | ||
|
|
||
| func defaultObjectNameSpace() string { | ||
| return cluster.TrafficNamespace(cluster.NamespaceDefault) | ||
| // trafficObjectStatusNamespace return namespace of traffic object status. |
There was a problem hiding this comment.
I can't understand this comment, what does it mean? And the following line also contains confusing grammar.
There was a problem hiding this comment.
for non-traffic objects, like autocertmanager, it is in namespace default, and its status is in namespace default.
but for traffic objects, they are managed by traffic controller, and traffic controller use specially prefix for status. for example, if a pipeline in namesapce default, then its status in namespace eg-traffic-default.
| @@ -99,12 +97,6 @@ var _ easemonitor.Metricer = (*TrafficObjectStatus)(nil) | |||
|
|
|||
| func init() { | |||
| supervisor.Register(&TrafficController{}) | |||
| api.RegisterObject(&api.APIResource{ | |||
There was a problem hiding this comment.
Why delete this registration?
There was a problem hiding this comment.
cycle import, i move this registration to api pkg. it can't be solved by other way... i try it several times.
Co-authored-by: Yun Long <[email protected]>
Co-authored-by: Yun Long <[email protected]>
Co-authored-by: Yun Long <[email protected]>
Co-authored-by: Yun Long <[email protected]>
In Easegress, when using
IngressController,MeshController, orGatewayController, resources such asHTTPServersandPipelinesare created in separate namespaces to prevent conflicts. To access these resources, you can utilize the--namespaceor--all-namespacesargument foregctl getoregctl describecommand.This pr also fix some previous bugs about get status. In easegress, status and config of traffic object are put into different namespace.
For example, autocertmanager in default namespace, then its status is in default namespace too. But for httpserver (which is traffic object), if httpserver is in default namespace, then its status is in eg-traffic-default. When store status, traffic controller use a special prefix for it.