Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egctl create httpproxy cmd support update or create autocertmanager #1188

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

suchen-sci
Copy link
Contributor

No description provided.

@suchen-sci suchen-sci marked this pull request as draft January 5, 2024 06:55
@codecov-commenter
Copy link

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (2dc8e98) 81.07% compared to head (3980390) 80.85%.
Report is 3 commits behind head on main.

Files Patch % Lines
cmd/client/commandv2/create/createhttpproxy.go 38.66% 35 Missing and 11 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1188      +/-   ##
==========================================
- Coverage   81.07%   80.85%   -0.23%     
==========================================
  Files         149      149              
  Lines       16967    17042      +75     
==========================================
+ Hits        13756    13779      +23     
- Misses       2558     2594      +36     
- Partials      653      669      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suchen-sci suchen-sci marked this pull request as ready for review January 5, 2024 09:22
@xxx7xxxx xxx7xxxx added this pull request to the merge queue Jan 5, 2024
Merged via the queue into easegress-io:main with commit b5f08e1 Jan 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants