Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exportable custom plain logger #1171

Merged
merged 3 commits into from
Jan 6, 2024

Conversation

cyrnicolase
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (2dc8e98) 81.07% compared to head (622a454) 79.89%.

Files Patch % Lines
pkg/logger/hub.go 58.82% 7 Missing ⚠️
pkg/logger/export.go 71.42% 2 Missing ⚠️
pkg/logger/logger.go 90.47% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
- Coverage   81.07%   79.89%   -1.19%     
==========================================
  Files         149      153       +4     
  Lines       16967    17316     +349     
==========================================
+ Hits        13756    13834      +78     
- Misses       2558     2818     +260     
- Partials      653      664      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* add copyright
* remove unused function
@cyrnicolase
Copy link
Contributor Author

图片

What's wrong ?

@suchen-sci
Copy link
Contributor

suchen-sci commented Dec 28, 2023

image

Your test case path is not working in windows os.
@cyrnicolase

@cyrnicolase
Copy link
Contributor Author

It's so sad!

@xxx7xxxx
Copy link
Contributor

For creating and manipulating OS-specific paths directly use os.PathSeparator and the path/filepath package.

@cyrnicolase
Copy link
Contributor Author

@suchen-sci @xxx7xxxx Could you please review the code for me?

@suchen-sci suchen-sci added this pull request to the merge queue Jan 6, 2024
Merged via the queue into easegress-io:main with commit d301c81 Jan 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants