Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wsproxy keepHost bug #1168

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

cyrnicolase
Copy link
Contributor

* fix wsproxy keepHost bug
@suchen-sci
Copy link
Contributor

suchen-sci commented Dec 19, 2023

Hi, can you also help update this doc https://github.com/megaease/easegress/blob/main/docs/02.Tutorials/2.6.Websocket.md and https://github.com/megaease/easegress/blob/main/docs/07.Reference/7.02.Filters.md#websocketproxy for future users to avoid this problem? Maybe add a simple example to it?

* Updating the section of the documentation regarding WebSockets.
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f0842a) 81.01% compared to head (88751bb) 81.03%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
+ Coverage   81.01%   81.03%   +0.02%     
==========================================
  Files         149      149              
  Lines       16962    16967       +5     
==========================================
+ Hits        13741    13749       +8     
+ Misses       2564     2562       -2     
+ Partials      657      656       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suchen-sci suchen-sci added this pull request to the merge queue Dec 20, 2023
Merged via the queue into easegress-io:main with commit 2dc8e98 Dec 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants