Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check #1143

Merged
merged 9 commits into from
Dec 4, 2023
Merged

Health check #1143

merged 9 commits into from
Dec 4, 2023

Conversation

suchen-sci
Copy link
Contributor

No description provided.

@suchen-sci suchen-sci marked this pull request as draft November 29, 2023 07:46
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (84ad751) 81.25% compared to head (e7aa799) 81.18%.
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/filters/proxies/httpproxy/healthcheck.go 82.95% 37 Missing and 15 partials ⚠️
pkg/filters/proxies/httpproxy/pool.go 52.17% 8 Missing and 3 partials ⚠️
pkg/filters/proxies/healthcheck.go 66.66% 3 Missing ⚠️
pkg/filters/proxies/loadbalance.go 91.66% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
- Coverage   81.25%   81.18%   -0.07%     
==========================================
  Files         148      149       +1     
  Lines       16620    16941     +321     
==========================================
+ Hits        13505    13754     +249     
- Misses       2474     2530      +56     
- Partials      641      657      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suchen-sci suchen-sci marked this pull request as ready for review December 1, 2023 10:48
interval: 60s

# uri for health check http request
uri: /health
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think path would be more precise here.

Copy link
Contributor Author

@suchen-sci suchen-sci Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uri contains path, and query part of url, which is more general. uri here means user can also put query part in yaml here.
This follows the design of nginx health check and caddy health check.

# response validation criteria (default: 2xx and 3xx status codes)
match:
# acceptable status code ranges
statusCode:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

statusCodes would be more correct grammatically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

# response validation criteria (default: 101 Switching Protocols)
match:
# acceptable status code ranges
statusCode:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@xxx7xxxx xxx7xxxx added this pull request to the merge queue Dec 4, 2023
Merged via the queue into easegress-io:main with commit a1496ab Dec 4, 2023
8 checks passed
@suchen-sci suchen-sci deleted the health-check branch December 4, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants