Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add egctl edit, egctl logs, update egctl create cmd #1067

Merged
merged 15 commits into from
Aug 31, 2023
Merged

add egctl edit, egctl logs, update egctl create cmd #1067

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
02a4901
add egctl edit command
suchen-sci Aug 18, 2023
c527116
add verbose flag for egctl describe
suchen-sci Aug 18, 2023
e7cc5b7
fix bug for edit custom data
suchen-sci Aug 18, 2023
fad067a
update egctl cheat sheet
suchen-sci Aug 18, 2023
0782333
finish egctl create httpproxy command, add some test
suchen-sci Aug 23, 2023
ff07cdb
add more test for egctl create cmd
suchen-sci Aug 24, 2023
392a393
add more test, add integration test
suchen-sci Aug 24, 2023
267f0a0
finish egctl logs command
suchen-sci Aug 25, 2023
023dafe
optim egctl logs command
suchen-sci Aug 25, 2023
afcf76a
add integration test for egctl logs
suchen-sci Aug 25, 2023
4b04d19
udpate doc, add examples
suchen-sci Aug 25, 2023
0d9548f
update based on github action
suchen-sci Aug 25, 2023
7f62308
close watcher
suchen-sci Aug 25, 2023
2ad235c
udpate based on comments
suchen-sci Aug 28, 2023
b38fc6b
update egctl edit example
suchen-sci Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update egctl edit example
  • Loading branch information
@suchen-sci
suchen-sci committed Aug 30, 2023
commit b38fc6b59f895c769dccb36e3713ac77695443cf
1 change: 1 addition & 0 deletions cmd/client/commandv2/edit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import (
func EditCmd() *cobra.Command {
examples := []general.Example{
{Desc: "Edit a resource with name", Command: "egctl edit <resource> <name>"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we specify editor like vim, nano.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in egctl-cheat-sheet.md, mentioned use of env variable of EGCTL_EDITOR to change editor. I will add an example about that in examples.

{Desc: "Edit a resource with nano", Command: "env EGCTL_EDITOR=nano egctl edit <resource> <name>"},
{Desc: "Edit a httpserver with name", Command: "egctl edit httpserver httpserver-demo"},
{Desc: "Edit all custom data with kind name", Command: "egctl edit customdata kind1"},
{Desc: "Edit custom data with kind name and id name", Command: "egctl edit customdata kind1 data1"},
Expand Down
Loading