Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove go.mod replace #1046

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

suchen-sci
Copy link
Contributor

@suchen-sci suchen-sci commented Jul 28, 2023

This pr removes replace in go.mod. replace in go.mod is used for local development.
When use go get github.com/megaease/easegress/v2 to get easegress, golang will not keep the replace part. Which will cause bugs during go build.

Comment on lines -293 to -296
github.com/buger/jsonparser => github.com/buger/jsonparser v1.1.1
github.com/go-openapi/spec => github.com/go-openapi/spec v0.19.3
sigs.k8s.io/kustomize/api => sigs.k8s.io/kustomize/api v0.12.1
sigs.k8s.io/kustomize/kyaml => sigs.k8s.io/kustomize/kyaml v0.13.9
Copy link
Contributor Author

@suchen-sci suchen-sci Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.com/buger/jsonparser => github.com/buger/jsonparser v1.1.1 in require is already v1.1.1. So, remove it changes nothing.

github.com/go-openapi/spec => github.com/go-openapi/spec v0.19.3 is not used anymore.

sigs.k8s.io/kustomize/api => sigs.k8s.io/kustomize/api v0.12.1 and sigs.k8s.io/kustomize/kyaml => sigs.k8s.io/kustomize/kyaml v0.13.9 are updated directly in require.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (3904080) 81.56% compared to head (ccc0cbb) 81.62%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1046      +/-   ##
==========================================
+ Coverage   81.56%   81.62%   +0.05%     
==========================================
  Files         135      135              
  Lines       15121    15121              
==========================================
+ Hits        12334    12343       +9     
+ Misses       2228     2219       -9     
  Partials      559      559              
Files Changed Coverage Δ
pkg/cluster/cluster.go 61.15% <ø> (ø)
pkg/cluster/cluster_interface.go 100.00% <ø> (ø)
pkg/cluster/config.go 94.82% <ø> (ø)
pkg/cluster/customdata/customdata.go 74.30% <ø> (ø)
pkg/cluster/member.go 70.81% <ø> (ø)
pkg/cluster/syncer.go 88.46% <ø> (ø)
pkg/cluster/test_util.go 94.11% <ø> (ø)
pkg/cluster/watcher.go 100.00% <ø> (ø)
pkg/filters/builder/builder.go 100.00% <ø> (ø)
pkg/filters/builder/databuilder.go 79.06% <ø> (ø)
... and 85 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suchen-sci suchen-sci added this pull request to the merge queue Jul 28, 2023
Merged via the queue into easegress-io:main with commit c4bc656 Jul 28, 2023
7 checks passed
@suchen-sci suchen-sci deleted the remove-go-mod-replace branch July 28, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants