Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve test coverage #1014

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Conversation

suchen-sci
Copy link
Contributor

No description provided.

@suchen-sci suchen-sci marked this pull request as draft June 1, 2023 07:42
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Patch coverage: 55.29% and project coverage change: +2.28 🎉

Comparison is base (f3e6c63) 79.84% compared to head (ab11cae) 82.12%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1014      +/-   ##
==========================================
+ Coverage   79.84%   82.12%   +2.28%     
==========================================
  Files         135      135              
  Lines       14956    14972      +16     
==========================================
+ Hits        11941    12296     +355     
+ Misses       2410     2122     -288     
+ Partials      605      554      -51     
Impacted Files Coverage Δ
pkg/cluster/layout.go 100.00% <ø> (+14.28%) ⬆️
pkg/cluster/op.go 94.51% <ø> (+28.04%) ⬆️
pkg/object/mqttproxy/broker.go 72.81% <32.35%> (-0.91%) ⬇️
pkg/object/mqttproxy/client.go 76.92% <50.00%> (-0.54%) ⬇️
pkg/object/mqttproxy/session.go 79.16% <70.45%> (+11.45%) ⬆️
pkg/cluster/syncer.go 88.46% <100.00%> (+6.41%) ⬆️
pkg/object/mqttproxy/sessioncache.go 100.00% <100.00%> (+40.40%) ⬆️

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@suchen-sci suchen-sci marked this pull request as ready for review June 2, 2023 02:58
@localvar localvar enabled auto-merge June 2, 2023 05:47
@suchen-sci suchen-sci marked this pull request as draft June 5, 2023 09:26
auto-merge was automatically disabled June 5, 2023 09:26

Pull request was converted to draft

@suchen-sci suchen-sci marked this pull request as ready for review June 6, 2023 09:37
@suchen-sci suchen-sci added this pull request to the merge queue Jun 6, 2023
Merged via the queue into easegress-io:main with commit 98f7b36 Jun 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants