Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group configurations by a single Yaml file #29

Closed
zhao-kun opened this issue Jun 16, 2021 · 1 comment · Fixed by #230
Closed

Group configurations by a single Yaml file #29

zhao-kun opened this issue Jun 16, 2021 · 1 comment · Fixed by #230
Assignees
Labels
enhancement New feature or request

Comments

@zhao-kun
Copy link
Collaborator

zhao-kun commented Jun 16, 2021

Many applications require multiple configurations to be created, such as an HttpServer and a PipelineFilter. Management of multiple configurations that grouped together in a single file (separated by --- in YAML) will bring huge simplicity to users.
like Kubernetes [1]

[1] https://kubernetes.io/docs/concepts/cluster-administration/manage-deployment/

@zhao-kun zhao-kun added the enhancement New feature or request label Jun 16, 2021
@zhao-kun zhao-kun changed the title Group configuration by a single Yaml file Group configurations by a single Yaml file Jun 16, 2021
@benja-wu
Copy link
Contributor

I agree this feature can bring huge simplicity for Easegress CLI users. Since we are dealing with manage API framework replacement, I will implement this feature as soon as the replacement completed.

@zhao-kun zhao-kun added this to To do in Easegress Project Jun 17, 2021
Easegress Project automation moved this from To do to Done Sep 7, 2021
benja-wu pushed a commit that referenced this issue Sep 7, 2021
* improve egctl to support sending multi configs at once (fix #29)

* add a visitor to do the YAML parsing

* rollback function readFromFileOrStdin

* Update comments.

Co-authored-by: Bomin Zhang <[email protected]>

* some improvements
- change the signature of VisitorFunc
- remove useless function readFromFileOrStdin

Co-authored-by: Bomin Zhang <[email protected]>
xmh19936688 referenced this issue in xmh19936688/easegress Sep 13, 2021
…egress-io#230)

* improve egctl to support sending multi configs at once (fix #29)

* add a visitor to do the YAML parsing

* rollback function readFromFileOrStdin

* Update comments.

Co-authored-by: Bomin Zhang <[email protected]>

* some improvements
- change the signature of VisitorFunc
- remove useless function readFromFileOrStdin

Co-authored-by: Bomin Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants