chore: slice replace loop

easegress-io · Jul 8, 2023 · 5f34fa6 · 5f34fa6
1 parent 3cadfce
commit 5f34fa6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/pkg/object/consulserviceregistry/client.go b/pkg/object/consulserviceregistry/client.go
@@ -72,9 +72,7 @@ func (c *consulAPIClient) ListAllServiceInstances() ([]*api.CatalogService, erro
  return nil, fmt.Errorf("pull catalog service %s failed: %v", serviceName, err)
  }
 
- for _, service := range services {
- catalogServices = append(catalogServices, service)
- }
+ catalogServices = append(catalogServices, services...)
  }
 
  return catalogServices, nil

diff --git a/pkg/object/serviceregistry/service.go b/pkg/object/serviceregistry/service.go
@@ -51,9 +51,7 @@ func (s *ServiceInstanceSpec) DeepCopy() *ServiceInstanceSpec {
  copy := *s
 
  if s.Tags != nil {
- for _, tag := range s.Tags {
- copy.Tags = append(copy.Tags, tag)
- }
+ copy.Tags = append(copy.Tags, s.Tags...)
  }
 
  return &copy