[log] Uses buffered IO for gateway.log

In such heavry write scenario, even for product stage, like high follow-control case,
the gateway log writes will be a minor bottleneck.

src/logger/http.go

@@ -21,13 +21,15 @@ var (
 )
 
 func initHTTP() {
+ formatter := new(httpFormatter)
+
  f, out, err := openBufferedLogFile(LOG_HTTP_ACCESS_FILE)
  if err != nil {
  Errorf("[open log file %s failed: %v]", LOG_HTTP_ACCESS_FILE, err)
+ } else {
+ httpLog.registerFileLogger("http_access", f, out, LOG_HTTP_ACCESS_FILE, formatter, LOG_HTTP_LEVEL)
  }
 
- httpLog.registerFileLogger("http_access", f, out, LOG_HTTP_ACCESS_FILE, &httpFormatter{}, LOG_HTTP_LEVEL)
-
  // test example:
  // req := httptest.NewRequest("POST", "https://127.0.0.1/api/sessions", nil)
  // req.Header.Set("Referer", "http:https://easeteam.com/login")
@@ -39,7 +41,7 @@ func initHTTP() {
  Errorf("[open log file %s failed: %v]", LOG_HTTP_DUMP_FILE, err)
  } else {
  // no buffer for performance, normally dump for debug or functional test only
- httpLog.registerFileLogger("http_dump", f, f, LOG_HTTP_DUMP_FILE, &httpFormatter{}, LOG_HTTP_LEVEL)
+ httpLog.registerFileLogger("http_dump", f, f, LOG_HTTP_DUMP_FILE, formatter, LOG_HTTP_LEVEL)
  }
 }
 

src/logger/logger.go

@@ -99,6 +99,7 @@ func openLogFile(fileName string) (*os.File, error) {
 }
 
 type bufWriter struct {
+ fileName string
  w *bufio.Writer
  wLock sync.Mutex
  data chan []byte // channel used as a write queue to smooth periodic flush peak
@@ -108,12 +109,13 @@ type bufWriter struct {
  done chan *struct{}
 }
 
-func newBufWriter(w io.Writer) *bufWriter {
+func newBufWriter(w io.Writer, fileName string) *bufWriter {
  bw := &bufWriter{
- w: bufio.NewWriterSize(w, 512), // block size for general VFS
- data: make(chan []byte, 2048),
- stop: make(chan struct{}),
- done: make(chan *struct{}),
+ fileName: fileName,
+ w: bufio.NewWriterSize(w, 512), // block size for general VFS
+ data: make(chan []byte, 2048),
+ stop: make(chan struct{}),
+ done: make(chan *struct{}),
  }
 
  flusher := func() {
@@ -164,7 +166,7 @@ func (bw *bufWriter) Close() {
  }
 
  for len(bw.data) > 0 {
- Debugf("[spin to wait log data writes completely]")
+ Debugf("[spin to wait flushing log data to %s]", bw.fileName)
  time.Sleep(time.Millisecond)
  }
 
@@ -195,7 +197,7 @@ func openBufferedLogFile(fileName string) (*os.File, io.Writer, error) {
  return nil, nil, err
  }
 
- out := newBufWriter(f)
+ out := newBufWriter(f, fileName)
 
  return f, out, nil
 }

src/logger/memberlist.go

@@ -28,6 +28,7 @@ func initMemberList() {
  LOG_MEMBERLIST_TTY_LEVEL = logrus.InfoLevel
  LOG_MEMBERLIST_LEVEL = logrus.InfoLevel
  }
+
  formatter := &logrus.TextFormatter{
  FullTimestamp: true,
  }

src/logger/std.go

@@ -21,17 +21,18 @@ func initStd() {
  LOG_STD_LEVEL = logrus.InfoLevel
  LOG_STD_TTY_LEVEL = logrus.InfoLevel
  }
+
  formatter := &logrus.TextFormatter{
  FullTimestamp: true,
  }
 
  std.registerIOLogger("stdio", os.Stdout, formatter, LOG_STD_TTY_LEVEL)
 
- f, err := openLogFile(LOG_STD_FILE)
+ f, out, err := openBufferedLogFile(LOG_STD_FILE)
  if err != nil {
  Errorf("[open log file %s failed: %v]", LOG_STD_FILE, err)
  } else {
- std.registerFileLogger("stdio", f, f, LOG_STD_FILE, formatter, LOG_STD_LEVEL)
+ std.registerFileLogger("stdio", f, out, LOG_STD_FILE, formatter, LOG_STD_LEVEL)
  }
 }