Compatibility additions #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a string error and switched to uint32_t
…dition Update bnkextr.cpp
eXpl0it3r
requested changes
Jan 8, 2019
bnkextr.cpp
Outdated
| @@ -47,6 +47,8 @@ ENVS | |||
| #include <fstream> | |||
| #include <iostream> | |||
| #include <vector> | |||
| #include <string> | |||
| #include <stdint.h> | |||
bnkextr.cpp
Outdated
| @@ -56,14 +58,14 @@ struct Index | |||
| { | |||
| int unknown; | |||
| int offset; | |||
| unsigned int size; | |||
| uint32_t size; | |||
There was a problem hiding this comment.
I'd go with std::uint32_t. Can you also use std::int32_t for the two ints above?
bnkextr.cpp
Outdated
| }; | ||
|
|
||
| #pragma pack(push, 1) | ||
| struct Section | ||
| { | ||
| char sign[4]; | ||
| unsigned int size; | ||
| uint32_t size; |
eXpl0it3r
approved these changes
Jan 8, 2019
eXpl0it3r
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added #include because the std's don't work without (no idea how it worked without the include on your end? But on my end it didn't work without it). And changed to uint32_t :)