Fix bug to dedicated flusher #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greensky00
reviewed
Sep 10, 2024
src/flusher.h
Outdated
| @@ -73,17 +73,20 @@ class FlusherQueue { | |||
|
|
|||
| class Flusher : public WorkerBase { | |||
| public: | |||
| enum FlusherType { GENERIC = 0x0, ONLY_HANDLE_ASYNC = 0x1, ONLY_HANDLE_SYNC = 0x2 }; | |||
There was a problem hiding this comment.
While I agree on GENERIC for non-dedicated situation, but the other two need to be renamed. Actually both are async processing. I'd rather name them
enum FlusherType { GENERIC = 0x0, FLUSH_ON_DEMAND = 0x1, FLUSH_ON_CONDITION = 0x2 };
src/db_mgr.cc
Outdated
Comment on lines
106
to
110
| std::string t_name = flusher_type == Flusher::FlusherType::ONLY_HANDLE_ASYNC | ||
| ? "flusher_async_" + std::to_string(ii) | ||
| : (flusher_type == Flusher::FlusherType::ONLY_HANDLE_SYNC | ||
| ? "flusher_sync_" + std::to_string(ii) | ||
| : "flusher_generic_" + std::to_string(ii)); |
There was a problem hiding this comment.
Same as below, I'd rather do flusher, flusher_od, flusher_oc. Also using switch will be better for readability.
There was a problem hiding this comment.
I agree with flusher_od and flusher_oc, but should we do flusher_gen for GENERIC case? Because the worker invocation is prefix base. Though GENERIC and ON_DEMAND/ON_CONDITION is kind of mutual exclusive.
greensky00
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.