Add dedicated flusher for syncOnly #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZexiLiu
commented
Aug 6, 2024
| @@ -16,6 +16,7 @@ limitations under the License. | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include "internal_helper.h" | |||
There was a problem hiding this comment.
This is for NOT_INITIALIZED.
greensky00
reviewed
Aug 6, 2024
include/libjungle/db_config.h
Outdated
| * normal data store are used. Only effective when | ||
| * `numFlusherThreads` >= 2. | ||
| */ | ||
| bool dedicatedSyncOnlyFlusher; |
There was a problem hiding this comment.
Let's change the config name, given that the flusher with this will handle the requests by flushLogsAsync, no matter what the request is (sync, flush, purge, ...).
I think dedicatedFlusherForAsyncReqs will be better.
src/flusher.h
Outdated
| @@ -82,6 +83,7 @@ class Flusher : public WorkerBase { | |||
|
|
|||
| GlobalConfig gConfig; | |||
| size_t lastCheckedFileIndex; | |||
| bool handleSyncOnly; | |||
There was a problem hiding this comment.
Same as above, handleAsyncReqsOnly.
greensky00
reviewed
Aug 6, 2024
src/db_mgr.cc
Outdated
| @@ -21,6 +21,7 @@ limitations under the License. | |||
| #include "db_internal.h" | |||
| #include "flusher.h" | |||
| #include "internal_helper.h" | |||
| #include "libjungle/db_config.h" | |||
There was a problem hiding this comment.
Can you move this after log_reclaimer.h and before <set>? Should be treated as 3rd party header.
greensky00
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the assumption that the async flusher queue is only used for log store.